Repository navigation
[CAS] Add llvm-cas tools to inspect on-disk LLVMCAS - #166481
Merged
cachemeifyoucan merged 1 commit intoNov 7, 2025
Merged
cachemeifyoucan merged 1 commit into
cachemeifyoucan merged 1 commit into
Conversation
Created using spr 1.3.7
cachemeifyoucan
requested review from
adrian-prantl,
bogner,
ilovepi and
petrhosek
November 5, 2025 01:02
cachemeifyoucan
changed the title
petrhosek
reviewed
Nov 5, 2025
|
|
||
| class F<string name> : Flag<["--", "-"], name>; | ||
|
|
||
| def grp_action : OptionGroup<"Actions">, HelpText<"llvm-cas actions">; |
Member
There was a problem hiding this comment.
Have you considered using subcommands for actions? The subcommand support was introduced in #155026.
Contributor
Author
There was a problem hiding this comment.
I am aware. But we ship this tool already. I would like to prevent breaking current command-line interface if possible.
Contributor
There was a problem hiding this comment.
Is it possible to migrate them over the course of a release or two?
Contributor
Author
There was a problem hiding this comment.
Maybe. I would like to do it incrementally since we need to teach build system about the new command before we can break the old one.
Member
There was a problem hiding this comment.
We should be able to support both syntaxes to avoid breaking existing uses and mark the flag-based versions as deprecated so new users are encouraged to use the subcommand syntax. I'm fine doing it in a follow up change if you prefer.
Contributor
Author
There was a problem hiding this comment.
@petrhosek I think subcommand is not usable with positional arguments. That is a deal breaker for now to use subcommand parsing.
It would also be nice if a flag can be alias to a subcommand but that is not strictly needed.
Contributor
There was a problem hiding this comment.
@cachemeifyoucan -- I responded about positional argument handling in the bug. PTAL.
Contributor
Author
|
Ping. Since sub-command parsing needs a bit polish. I think I will update to that in the future. |
petrhosek
approved these changes
Nov 7, 2025
cachemeifyoucan
deleted the
users/cachemeifyoucan/spr/cas-add-llvm-cas-tools-to-inspect-on-disk-llvmcas-114104
branch
November 7, 2025 18:32
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/154/builds/23754 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/21935 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/23/builds/15355 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/39/builds/8594 Here is the relevant piece of the build log for the reference |
Contributor
Author
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/95/builds/19031 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/201/builds/7000 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/76/builds/13353 Here is the relevant piece of the build log for the reference |
Contributor
Author
Member
If I remember correctly, the I think ultimately, as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a command-line tool
llvm-casto inspect the OnDisk CAS fordebugging purpose. It can be used to lookup/update ObjectStore or
put/get cache entries from ActionCache, together with other debugging
capabilities.